• Corrects EnableAdcChannels parameter format from binary to decimal
• Updates XML docs with accurate decimal bitmask examples
• Fixes README and DEVICE_INTERFACES.md code examples
• Updates unit test to use correct decimal format

Update test to use decimal bitmask format

• Changed EnableAdcChannels test from binary string "0001010100" to decimal "84"
• Updated expected command output to use decimal format

src/Daqifi.Core.Tests/Communication/Producers/ScpiMessageProducerTests.cs

Correct EnableAdcChannels XML docs to decimal format

• Updated XML documentation to clarify decimal bitmask format instead of binary
• Changed parameter description from binary string to decimal integer string
• Updated code examples to show decimal values (e.g., "84" for channels 2,4,6 and "3" for channels
 0,1)
• Added explanation of bit-to-channel mapping with decimal values

src/Daqifi.Core/Communication/Producers/ScpiMessageProducer.cs

Update StartLoggingAsync docs to decimal bitmask

• Updated channelMask parameter documentation from binary to decimal format
• Changed example from "0000000011" to "3"
• Added clarification that firmware parses as decimal integer

src/Daqifi.Core/Device/DaqifiStreamingDevice.cs

Description

After updating core docs to specify a decimal bitmask for ENAble:VOLTage:DC, the simulator
documentation still describes the parameter as a binary string and shows base-2 parsing. This leaves
contradictory guidance in-repo and can lead to an incorrect simulator implementation that won’t
match firmware behavior.

Code

src/Daqifi.Core/Communication/Producers/ScpiMessageProducer.cs[R318-336]

  /// <summary>
-    /// Creates a command message to enable ADC channels using a binary string.
+    /// Creates a command message to enable ADC channels using a decimal bitmask.
  /// </summary>
-    /// <param name="channelSetString">A binary string where each character represents a channel (0 = disabled, 1 = enabled), right-to-left. For example, "0001010100" enables channels 2, 4, and 6.</param>
+    /// <param name="channelSetString">A decimal integer string representing a bitmask where each bit enables a channel. For example, "84" (0b1010100) enables channels 2, 4, and 6.</param>
  /// <remarks>
-    /// The binary string is read from right to left, where position 0 is the rightmost bit:
-    /// - Position 0: Channel 0
-    /// - Position 1: Channel 1
-    /// - Position 2: Channel 2
+    /// The firmware parses this value as a decimal integer and interprets it as a bitmask:
+    /// - Bit 0 (value 1): Channel 0
+    /// - Bit 1 (value 2): Channel 1
+    /// - Bit 2 (value 4): Channel 2
  /// etc.
-    /// 
-    /// Command: ENAble:VOLTage:DC binaryString
-    /// Example: 
+    ///
+    /// Command: ENAble:VOLTage:DC decimalMask
  /// <code>
-    /// // Enable channels 2, 4, and 6
-    /// messageProducer.Send(ScpiMessageProducer.EnableAdcChannels("0001010100"));
-    /// 
-    /// // Enable channels 0 and 1
-    /// messageProducer.Send(ScpiMessageProducer.EnableAdcChannels("0000000011"));
+    /// // Enable channels 2, 4, and 6 (bitmask = 4 + 16 + 64 = 84)
+    /// device.Send(ScpiMessageProducer.EnableAdcChannels("84"));
+    ///
+    /// // Enable channels 0 and 1 (bitmask = 1 + 2 = 3)
+    /// device.Send(ScpiMessageProducer.EnableAdcChannels("3"));
  /// </code>

Evidence

Core docs now explicitly state the firmware parses the value as a decimal integer bitmask, but
simulator docs still specify `, show examples like 0000000011`, and even show
Convert.ToUInt32(binaryString, 2) parsing—contradicting the updated contract and recreating the
original mismatch in simulator guidance.

src/Daqifi.Core/Communication/Producers/ScpiMessageProducer.cs[318-341]
docs/simulator/SIMULATOR_DESIGN.md[139-160]
docs/simulator/SIMULATOR_DESIGN.md[404-416]
docs/simulator/SIMULATOR_IMPLEMENTATION_PLAN.md[583-590]
docs/simulator/GITHUB_ISSUES.md[258-266]
docs/simulator/GITHUB_ISSUES.md[280-287]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Simulator documentation still describes `ENAble:VOLTage:DC` as taking a binary string and shows base-2 parsing, which contradicts the updated core docs/tests that specify a decimal bitmask string.
### Issue Context
This PR corrects the public API documentation to match firmware behavior (decimal integer parsed as bitmask). Simulator docs should match the same contract to avoid future simulator/test implementations reintroducing the binary/decimal mismatch.
### Fix Focus Areas
- docs/simulator/SIMULATOR_DESIGN.md[139-160]
- docs/simulator/SIMULATOR_DESIGN.md[404-416]
- docs/simulator/SIMULATOR_IMPLEMENTATION_PLAN.md[583-590]
- docs/simulator/GITHUB_ISSUES.md[258-266]
- docs/simulator/GITHUB_ISSUES.md[280-287]
### What to change
- Replace `<binary_string>` with something like `<decimal_mask>` / `<decimal_bitmask>`.
- Update examples from `0000000011` to `3` (and similar).
- Update the simulator parsing example from `Convert.ToUInt32(binaryString, 2)` to decimal parsing (e.g., `Convert.ToUInt32(maskString)`), so it mirrors firmware behavior.
- Update the design doc’s example call `EnableAnalogChannels("0000000011")` to the correct API name and decimal value (e.g., `EnableAdcChannels("3")`), consistent with the rest of the repo.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools